Making It Easier To Start Working On Bugzilla

Frédéric Buclin LpSolit at gmail.com
Wed Dec 21 23:32:48 UTC 2005


> I would expect an r- if this was submitted by someone with a deep
> understanding of DBI and perl. But for a first time contributor...?

I don't think that making a distinction between a newbie and an 
experienced developer is a good idea when deciding to give a r+ or a r-. 
Either it worths a r+ or it doesn't. What I do when I review a newbie's 
patch is to give much more information on how to fix the patch 
correctly, to avoid him to resubmit again and again. For experienced 
developers, I only say the patch doesn't work and only briefly explain 
why, without indicating on how to fix it.

I think that's the best way to learn Perl and our Bugzilla-specific 
conventions.


LpSolit



More information about the developers mailing list