Making It Easier To Start Working On Bugzilla

[Gregary Hendricks]

>	Unless we're dealing with some area not covered in the
Developer's
>Guide (such as Object- Oriented architecture), review comments based
on
>style should be coming mostly from the Guide.

This usually deals with the way perl does things and I don't think we
would really want to include all of the perlisms in the developers
guide.

>> Just yesterday I spent litterally half my day helping rework a
patch
>> that  worked but wasn't "cool enough" to get accepted because it
>> didn't use a particular implimentation of an algorithm.

>	Which patch?

https://bugzilla.mozilla.org/show_bug.cgi?id=313571

Specificallly in dealing with the Slice. It took Justin and I several
hours of searching to figure out what this was and how it worked. His
previous patch worked just fine without it. Sure it wasn't the cleanest
perl code in existence, but this is Justin's first patch and neither of
us are perl gurus. Justin worked really hard to get a working solution
and it was a working solution. 
Now I am not complaining, in this case we both learned something that
will be useful next time we come accross a similar problem. But this
just hi-lights the point I was trying to make earlier: 
      For someone that is just starting out to have something like this
prevent an r+ is discouraging. 

LpSolit's review was very well done and each of his points here is
valid for making good code, but the master woodsmith does not expect
perfection from his apprentice on the first day or week of work. 
I would expect an r- if this was submitted by someone with a deep
understanding of DBI and perl. But for a first time contributor...?

This is a dilemma and I am not sure there is an easy solution. I just
think it needs further discussion. 

 
>>> bugreport at peshkin.net 12/21/05 2:33 pm >>> 
>This is quite a thread for making reviewers feel unappreciated.

This was not my intention. We really appreciate all the hard work and
effort that you all put into bugzilla.
Thank you. 

Greg Hendricks