Making It Easier To Start Working On Bugzilla

[Frédéric Buclin]

> I wholeheartly support your concerns for quality. But isn't that
> exactly the reviewers job? If he does pull a patch in, applying
> necessary changes, isn't that enough for quality? If it is not, then
> he possibly should stop review.

When there are minor remaining changes to apply, we often add comments 
such as "Fix that and that on checkin" and the one doing the checkin (in 
99% of cases, a reviewer) will apply them when commiting the patch. Or 
we ask to open another bug to fix some remaining issues. If there is 
more than that to fix, then we deny review. So we are not as "strict" as 
what you seem to say here.

But applying a patch on a new installation (to not conflict with our 
current work), doing necessary changes, and doing a "cvs diff" again, 
then commiting the patch and waiting for another reviewer to review it 
takes too much time, and we already have a long queue of pending 
reviews. So I prefer to say "Please fix that and I will r+ your patch" 
than doing it myself. This gives me more time for other reviews (I also 
try to have some free time for non-Bugzilla stuff... sometimes).

LpSolit