Making It Easier To Start Working On Bugzilla

Jochen Wiedmann jochen.wiedmann at gmail.com
Tue Dec 20 09:16:55 UTC 2005


On 12/20/05, David Miller <justdave at bugzilla.org> wrote:

> There's a couple different ways to look at this.  I know we often expect
> the contributor to fix up their own patch, mostly with the goal of
> letting them get sole credit for the patch when it goes in.  Some of us
> feel like we'd be stealing the glory from the contributor if we just
> took over the patch and fixed it up after they contribute it.

That's, IMO, not the point. The question is, whether I have to push a
patch ("against" the reviewer) or whether the reviewer pulls the
patch. Besides, if a person has such a large ego, that he or she is
unable to accept that a projects standards require some changes, then
he or she should possibly better work on a standalone project and not
in a team.

To me, Max approach (contributors guide), and yours ("Tell us if you
don't mind ...") are basically the same thing over and over again. You
create bureaucratic structures. But  bureaucreatic structures are also
limits for new developers. In other words: Your attempts will fail.
(At least, that's my opinion.)

I wholeheartly support your concerns for quality. But isn't that
exactly the reviewers job? If he does pull a patch in, applying
necessary changes, isn't that enough for quality? If it is not, then
he possibly should stop review.


Jochen

--
Often it does seem a pity that Noah and his party did not miss the
boat. (Mark Twain)




More information about the developers mailing list