Bradley Baetz bbaetz at
Thu Oct 24 08:20:42 UTC 2002

On Thu, 24 Oct 2002, David Miller wrote:

> How about if we require check-in approval now.  That won't count as a
> review, because I have enough development stuff I have to worry about with
> my own patches I'm working on to spend major time reviewing things, but as
> a "yes, this feature has been approved for adding to Bugzilla".  With the
> loss of a second-review in most cases, this is probably a good idea.

'eww' :)

We do require 2 reviews for schema changes, and the request stuff
certainly got at least 2 reviews, with several people looking over it. I 
still don't see a problem with per-component stuff for this. The problem 
with moving between products/components was noted _before_ checkin, and 
allowed to go through since the current code didn't handle it, ie it 
wasn't a regression.

You'll only need two screens when the flag isn't present in the new thing 
_and_ is set, and by the time a cvs account request has an 'account 
created' flag, one would hope that it was in the correct component. I 
really don't see this as a big deal


More information about the developers mailing list