Easier Patch Submission? Is it possible?
jochen.wiedmann at gmail.com
Wed Jan 20 13:47:18 UTC 2010
2010/1/20 Frédéric Buclin <lpsolit at gmail.com>:
> To avoid these problems, what I do more and more often is either 1) r+
> the patch and mention that I will do the numerous "fixes on checkin"
> myself, to avoid extra loops and to not demotivate the contributor, or
> 2) I ask the contributor if he agrees that I finalize his patch myself,
> so that he doesn't think I'm trying to steal his work and get all the
> credit. I think that's a better choice, but this requires some free time
> from the reviewer to update and test the patch, and is only doable if
> the reviewer has a real interest in the fix/feature and/or is able to
> reproduce the issue.
Both sound like good compromises to me.
> From what I can see, mkanat is following the same path, i.e. I see him
> doing a lot of fixes on checkin himself to not demotivate valuable
> contributors/contributions. But if we have no time and/or interest to do
> the fixes ourselves, we have no other choices than to r- the patch and
> to ask for an updated one.
Certainly. I'd never suggest the above policy if it adds time to the committer.
Germanys national anthem is the most boring in the world - how telling!
More information about the developers