Easier Patch Submission? Is it possible?

Michael Thomas mockodin at gmail.com
Tue Jan 19 19:37:28 UTC 2010


2010/1/19 Frédéric Buclin <lpsolit at gmail.com>

> Because nobody would review it. Also, you don't need to do a CVS diff. A
> local diff would work too.
>
> Actually meant that it would be nice if the patch file was created on
submission. Rather than client side. So the review process would be no
different.
Not saying that doing the diff is that hard, more that sometimes the 5
minutes it takes is 5 minutes someone might not have at a given moment in
time. The result being that a perfectly good fix or enhancement gets
relgated to the back burner and forgotten even though the work is already
done.


> Because Bugzilla would have no idea what the file is. When you attach
> plain text, the name of the file is not included. Bugzilla cannot guess.
>
> True, I'm not saying as of this second it would work, more that if the
appropriate tags were added the base files it would work, eg tag with
path/name and tag with version.

>
> Well, that's inaccurate as Bugzilla lets you view the whole file from a
> patch with only a few lines of context. That's how I always review
> patches. No need for the whole file.
>
> Ok figured that out: Click 'View attachment as Diff' then click 'File' in
"Context: (Patch / File)" so right in front of me :-)

>
> LpSolit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bugzilla.org/pipermail/developers/attachments/20100119/cd24240f/attachment.html>


More information about the developers mailing list