Easier Patch Submission? Is it possible?
lpsolit at gmail.com
Tue Jan 19 19:22:24 UTC 2010
Le 19. 01. 10 20:05, Michael Thomas a écrit :
> temptation, at least for me, is to submit the raw edited file rather than a
> cvs patch file. My question is why not?
Because nobody would review it. Also, you don't need to do a CVS diff. A
local diff would work too.
Why can't patch files be
> automatically derived on submission of a complete file or on-the-fly
> comparison on request.
Because Bugzilla would have no idea what the file is. When you attach
plain text, the name of the file is not included. Bugzilla cannot guess.
> The advantage of a complete file is context, a patch files shows only a
> subset of the the file relating to the changes but not necessarily how it
> relates to the rest of the code.
Well, that's inaccurate as Bugzilla lets you view the whole file from a
patch with only a few lines of context. That's how I always review
patches. No need for the whole file.
More information about the developers