Adding an XML-RPC to append comments

[Jeff Lasslett]

Thanks Mads,

Next time I make a patch I will definitely follow the guidelines you've
pointed out to me.  I guess I was informally offering up that bit of
code (Bug.remove).  I don't mind if it's not used.  :-)

Thanks also for the tip re: file permissions and diff.  I'll keep an eye
out for that.  :-)

I did notice the disciplined approach to documentation in the patch
245546.

Cheers,
	Jeff


On Mon, 2007-05-21 at 08:14 +0200, Mads Bondo Dydensborg wrote:
> torsdag 17 maj 2007 08:58 skrev Jeff Lasslett:
> > Thanks Max,
> > 
> > After patching the original (v3.0) Bug.pm with patch attachment #245546
> > 
> > My script produces the following when trying to call 'Bug.create':
> > 
> > I don't see why Bugzilla::WebService::Bug can no longer be located.
> 
> Risking the wrath of the gurus for answering this: I have found, that when 
> using "patch", it often changes the status bits of the files. I usually need 
> to chmod a bit to get it working again, or running the update script.
> 
> And, while I am at it, you need to read: 
> http://www.bugzilla.org/docs/contributor.html
> to understand the bugzilla "rules" on contributions. It will make it a lot 
> easier for you! :-)
> 
> Also, in order to get any patch for the XML-RPC accepted, you need to follow 
> the rules for returning error codes, and you need to document the methods you 
> add, following the rules for that! I know from experience, that it can take a 
> while to get it rigth == getting a reviewer to approve. OTOH, there is no 
> question that the sort-of rigid process improves the final result.
> 
> One of these days I will fix the stuff the reviewer (Max) has pointed out in 
> https://bugzilla.mozilla.org/show_bug.cgi?id=355847
> - currently waiting for a bugzilla 3.0 update on our main installation...
> 
> Regards,
> 
> Mads 
>