lpsolit at gmail.com
Mon Aug 7 21:11:55 UTC 2006
> Although, it does seem odd to say "This is our preferred style. But we
> haven't changed all the code to match because that would, er, involve
> changing the code."
No, this makes perfect sense. Bitrotting some patches awaiting review
only because we added or removed some whitespaces or moved a bracket on
its own line, etc... is a waste of time for everybody: for the developer
writing the patch as well as for the reviewer wasting his time reviewing
a patch which no longer applies correctly. And of course, in case you
have to backport your patch to branches, the probability that your patch
doesn't apply cleanly on branches is higher because we did some minor
changes on the trunk.
I'm against this kind of "cleanup" of the existing code. I spent a lot
of time backporting security patches lately, so I know how painful this
More information about the developers