When is this code block accessed? [aka search comments, by comment entry date]

Christian Robottom Reis kiko at async.com.br
Thu Mar 11 14:34:26 UTC 2004


On Tue, Mar 09, 2004 at 11:21:17PM -0500, Matthew A. R. Sherian wrote:
> have activity (in my environment cvs checkins). In my quest to ascertain a
> method by which this may be achieved I have come accross the section
> 
> [% BLOCK a_comment %]
>   [% IF count > 0 %]
>     <br>
>     <i>------- Additional Comment
>       <a name="c[% count %]" href="#c[% count %]">#[% count %]</a> From <a
>       href="mailto:[% comment.email FILTER html %]">[% comment.name FILTER
>       html %]</a> [%+ comment.time %] -------
>     </i>
>   [% END %]
> 
> in bug/comments.html.tmpl.

Yes, this is the comment header, which is echoed before each comment in
a bug report (show_bug). It's quite unrelated to the code below:

> I also have lines 525-530 of buglist.cgi:
>     my @funcdefs =
> <snip>
>          "^long_?desc,changedafter" => sub {
>              my $table = "longdescs_$chartid";
>              push(@supptables, "longdescs $table"); push(@wherepart,
>              "$table.bug_id = bugs.bug_id"); $term = "$table.bug_when > "
>              . SqlQuote(SqlifyDate($v));
>          },
> </snip>
> 
> however it appears that funcdefs is just an abandoned data structure.

This now lives in Search.pm, though I don't see why funcdefs is an
"abandoned data structure".

> I also inserted a new row into fielddefs and had it's name column set to
> longdescs.bug_when and then tried a drop_down OR search. This seems to
> work but only for a small subset of bugs that have comments on or after a
> date.

Look at the SQL being generated and do a query manually to see what
should be happening that isn't?

Take care,
--
Christian Robottom Reis | http://async.com.br/~kiko/ | [+55 16] 261 2331



More information about the developers mailing list