DevGuide Comments

Christian Robottom Reis kiko at
Mon Dec 22 17:24:35 UTC 2003

This is redundant, but it was stuck in my queue so here it goes.

On Fri, Dec 19, 2003 at 04:25:01PM +1030, MattyT wrote:
> > 	+ In the "submitting your patch" section, you might want to mention
> > about what directory level to run a diff -Nru from, if it spans multiple
> > directories. It would mean that people applying patches wouldn't have to
> > worry about whether it was -p0 or -p1 or no -p at all.
> I'm not sure we should specify this.  Shouldn't it be obvious from the
> context?  Sometimes people might have multiple changes to their tree,
> but only want to diff one subdirectory.  Or does it work if you do it
> from Bugzilla root and specify a subdirectory?

Patches should always be generated from the Bugzilla root -- otherwise,
you'll need to futz with -pX to ensure it applies without prompts. Yes,
it works when you do a cvs diff from the Bugzilla root and specify a
subdir -- in fact, it's the right way to do it!

> > 	+ "first-review" and "second-review" are "review" and "super-review"
> > now, aren't they?
> Probably.  I'll change it when I hear the full procedure outlined.

Actually, it's review and approval.

Take care,
Christian Robottom Reis | | [+55 16] 261 2331

More information about the developers mailing list