2.18 Goals

Gervase Markham gerv at mozilla.org
Fri Sep 13 17:54:02 UTC 2002

> Of course, it would be nice if someone with perl 
> knowledge could review the patch at http://mozilla.flowerday.cx ,
> see bug 70907 comment #27 and #28 . The code has been there for quite 
> a while. Since it's not an attachment, I'm not sure how to
> request review for it with the request tracker... ;-)

File a bug for it and request review for that bug. But my initial 
reaction is: it needs templatising, and it doesn't conform to our coding 
style guidelines in various places. Also, it would be good if it didn't 
hard-code things in a way that meant it needed fixing for every schema 
change; but I don't know if that's possible.


More information about the developers mailing list