Self Introduction: Jay Harman

[Kent Rogers]

Hi Jay,

You need to get yourself a good source tree browser and/or learn to use
'find'. :-)

The only places I can tell that Object::check_time() is called are in
Comment.pm (to validate work_time) and Bug.pm (to validate estimated_time
and remaining_time).

Not sure what you mean by "accept that time as is", but I'm pretty sure you
will need to convert the value to a decimal for processing in the Comment
and/or Bug objects (see Bug::add_comment()).  The time fields in the DB are
decimals.

-Kent

On Wed, Jul 10, 2013 at 12:44:37PM -0700, Jay Harman wrote:
> Jay Harman
> JayHarman on IRC
> Portland, OR, USA
> Primarily a mathematics tutor.
> I'd like to help out with small bugs primarily - get to know the code
> before I work on anything huge.
> I did a lot of coding through high school and college, but haven't touched
> it in a few years. I'm looking to get back in the swing of things by
> helping out.
> 
> I've taken a look at the "good for beginners" list of bugs, and I wanted to
> ask a couple of questions about bug 464688. Right now the code in
> Bugzilla::Object has a validate time function, which I could pretty easily
> modify to allow for time in HH:MM format, but I don't know where in the
> greater code that function is being called - Would it be better to accept
> that time as is or to convert it to decimal time? It would be a smaller
> patch if I just accept the HH:MM format, but if there are functions that
> take the time that has been validated and assume it's in the current
> format(possibly for calculating total time on a project or sorting bugs by
> time spent), that would lead to more bugs. Are there such functions?
> 
> Thank you,
> Jay Harman