email interface into a module?

[Max Kanat-Alexander]

On Fri, 30 Nov 2007 17:51:59 -0800 Craig <craig5 at pobox.com> wrote:
> As a "first pass", what if all of the subroutines went into a module
> (Bugzilla::Email.pm) and everything below "Main Script" stayed in
> email_in.pl?

	I was thinking something more like Bugzilla::Bug::FromEmail,
but Bugzilla::EmailIn would be fine too. Bugzilla::Email would be
confusing.

> I have just started reading the developer doc... why doesn't
> email_in.pl use taint mode (-T)?

	No particular reason. It probably ought to.

> email_in.pl has "-w" and "use warnings". Isn't that redundant? If the
> version of perl being used doesn't support "use warnings", then it's
> going to die anyway, right?

	Well, we don't support any version of Perl that doesn't have
"use warnings."

	-w doesn't get activated if you run the script like
"perl ./email_in.pl", but "use warnings" does. For the CGIs, though,
having -w is pretty handy, because for example, in mod_perl you can
disable it easily (the PerlSwitches configuration variable) if you
need to. And I think our test suite actually demands we always have -w
on the #! line.

> Are you refering to the sections of Bug.pm that are preceded by:
> 	"Temporary hack until all of process_bug uses update()."

	No, I mean a function that can update a Bug by taking
parameters in the same way create() does.

	-Max
-- 
http://www.everythingsolved.com/
Competent, Friendly Bugzilla and Perl Services. Everything Else, too.