bz_lock_tables - how much, how often?

Fergus Sullivan fergus at yahoo-inc.com
Thu Dec 21 08:27:37 UTC 2006


i've noticed mysql.pm (2.22) includes the following code:

sub bz_lock_tables {
     my ($self, @tables) = @_;

     my $list = join(', ', @tables);
     # Check first if there was no lock before
     if ($self->{private_bz_tables_locked}) {
         ThrowCodeError("already_locked", { current => $self-> 
{private_bz_tables_locked},
                                            new => $list });
     } else {
         $self->do('LOCK TABLE ' . $list);

         $self->{private_bz_tables_locked} = $list;
     }
}

bz_lock_tables (can i call it 'blt'?) appears to be invoked in places  
by buglist.cgi and query.cgi.

my bugzilla instance is a mixture of myisam an innodb.  should i be  
worried about blt?  shouldn't  the locking rules for innodb be very  
different to those for myisam?  especially when reading, as opposed  
to writing.

given we LOCK TABLE.$list, what does $list consist of?  everything  
we're SELECTing?

thanks

  /ferg

--
fergus sullivan | yahoo bugzilla admin | fergus at yahoo-inc.com | o.  
408.349.6807 | m. 408.xxx.xxxx






More information about the developers mailing list