"Auto Detect" for attachment content type.

[Max Kanat-Alexander]

On Wed, 2006-04-05 at 21:28 -0400, David Miller wrote:
> byron jones wrote on 4/5/06 9:00 PM:
> >>> buglist.cgi: -content_disposition => "$disp; filename=$filename");
> >> Just figured out there's a potential bug there - $filename should have
> >> "'s around it.
> > 
> > and encoded if it's more than 78 chars, or non-ascii.
> 
> please research old bugs before touching this.
> 
> It was broken on several browsers a year or two ago, and it got 
> researched the hell out of to find out how to do it right.  If it's 
> broken now, someone probably reverted it on accident.  Otherwise, it's 
> likely the way it is now on purpose.

	The way it is now is fine. :-) The line I pasted above is from
buglist.cgi. *We* set all the filenames on buglist.cgi.

	attachment.cgi does the exact right thing with user-supplied filenames.

	-Max
-- 
http://www.everythingsolved.com/
Competent, Friendly Bugzilla Services. And Everything Else, too.