Minor tip breakage in email prefs

[Gervase Markham]

Developers,

Having checked in bug 73665 (wahey!) the tip is slightly broken. This is 
because the checksetup.pl "precompilation" of templates doesn't actually 
precompile them right - for example, it misses out important things like 
constants. This means that the templates thereby produced don't work 
properly, and you have to recompile them the "proper" way to get them to 
work. Goodness knows how it worked properly up to now.

So, if you are having trouble with the email pref UI, then:

touch template/en/default/account/prefs/email.html.tmpl

and a Shift-Reload should sort you out - at least until you next run 
checksetup.pl.

The reason I'm emailing you rather than fixing it is because a) I don't 
know how to fix it correctly, and b) it's ten to midnight, and I'm about 
to turn into a pumpkin. I'll fix it tomorrow evening if we've 
collectively worked out how to do it by then.

The correct fix is probably to get checksetup.pl using Bugzilla/Template 
properly to do the precompilation. However, last time I tried to use 
Bugzilla::* modules in checksetup I got a stern talking-to ;-), so I'm 
not quite sure how to go about it. Suggestions welcome.

Note that the code is already very confused. Just after line 1200 it 
calls Template::Provider::new, passing it a load of parameters (such as 
FILTERS, PRE_CHOMP and TRIM) which it entirely ignores. Those are 
parameters designed for Template::new, which is something very different.

This is why adding CONSTANTS to that call, the "obvious" fix, has no 
effect whatsoever.

Gerv