importxml.pl, move.pl should not write to $datadir/maillog

Olav Vitters olav at bkor.dhs.org
Sun Mar 27 21:12:55 UTC 2005


The files importxml.pl and move.pl write to $datadir/maillog. The only
thing written to those files are:
(importxml.pl)
  Log($subject . " sent to: $to");

(move.pl)
  "XML: bugs $buglist sent to $to"

There is also code in BugMail.pm to write to this file but it has been
commented out (even in the initial commit).

I think this code should be removed. It isn't used by BugMail.pm, so
why is it in above files? It is only used to log email activity, but
BugMail.pm has it commented out.

Some background:
At bugzilla.gnome.org we use a forked importxml.pl containing the
logging. The importxml.pl is activated by an email message delivered
using Postfix. Postfix sets the 'file size' ulimit to 50MB (I think it
sets it to 5 times the configured max email message size).
Importxml.pl writes to the log after doing everything else (creating
the bug). A few days ago $datadir/maillog hit that 50MB and importxml.pl
aborted. At b.g.o this causes the message to be forwarded for
investigation. This problem is probably specific, but as the logging
does not serve a useful purpose (BugMail.pm is excluded), I think it
should be removed.

Anyone objects to removing this / commenting it out? If nobody objects
I'll create a patch for it.

-- 
Regards,
Olav



More information about the developers mailing list