E-mail notification of new attachments

[Sean McAfee]

A message from me not about custom fields!  Amazing!

Some folks at my workplace want a bug's assignee and CC list to be notified
whenever an attachment is added to the bug.  I thought this could be
accomplished simply by changing this line in subroutine insert() in
attachment.cgi:

  $vars->{'mailrecipients'} =  { 'changer' => $::COOKIE{'Bugzilla_login'} };

...to this:

  $vars->{'mailrecipients'} = {
    'changer' => $::COOKIE{'Bugzilla_login'},
    'cc'      => \@cclist
  };

...where I populate @cclist beforehand.  However, all members of the cc list
always end up on the mail's "excluded" list.  I've been trawling through the
innards of Bugzilla::BugMail to find out why this happens, and the best I
can tell, I get bounced out of NewProcessOnePerson() by this conditional:

if ($difftext eq "" && $newcomments eq "") { return; }

How this condition gets met, though, is proving difficult to determine.  So,
I'm punting to the list and hoping someone more familiar with the BugMail
guts can explain what's happening more quickly.


--Sean