Stalled custom field development

Benton, Kevin kevin.benton at amd.com
Wed Mar 23 16:30:15 UTC 2005


> Max Kanat-Alexander wrote:
> > On Tue, 2005-03-22 at 19:55, Max Kanat-Alexander wrote:
> >
> >>	I'd imagine that a structure similar to what we used for
userprefs
> >>would work for a lot of that. In this case, that means FAD.
> >
> > 	However, using FAC would allow us to keep our current Boolean
Chart
> > code, which is a big plus. FAD would require re-working the Boolean
> > Charts.
> >
> > 	I'll let Dave decide about this, though.
> 
> Yikes, and until that was pointed out, I was so close...
> 
> I finally got through a bunch of reading up on what's been going on
> here.  Max and I had a little discussion earlier tonight, also, and
he's
> attempting to file bugs (most of them are filed already by now
probably)
> to split up this monumental task into smaller pieces.  Most of them
> beyond step 1 are easy to do once step 1 is done.  Step 1 is a big one
> though, because it involves solving the above discussion.
> 
> Max: can you explain to me why FAD requires reworking boolean charts?
> We already have fields that require table joins in order to check
things
> from boolean charts, and if we know the field is in one of these
custom
> field tables, then that join can be manufactured pretty easily, just
> like any of the others.
> 
> $table = 'fieldname_chartnum';
> push @tables, "INNER JOIN customfields $table ON bugs.bug_id =
> $table.bug_id AND $table.fieldname='fieldname'";
> push @wherepart, "$table.value = $term";
> 
> That's psuedocode of course, don't trust my variable names. :)

Your pseudo code brings up a great point.  For readability, I think we
ought to get into the habit of using the optional "AS" when renaming
tables as a rule.  Max - keep up the evaluation of FAC vs. FAD and the
whole custom field development issue.  You're doing a fantastic job!  I
would be doing the same thing if I had more time to devote to it at the
moment.

---
Kevin Benton
Perl/Bugzilla Developer
Advanced Micro Devices
 
The opinions stated in this communication do not necessarily reflect the
view of Advanced Micro Devices and have not been reviewed by management.
This communication may contain sensitive and/or confidential and/or
proprietary information.  Distribution of such information is strictly
prohibited without prior consent of Advanced Micro Devices.  This
communication is for the intended recipient(s) only.  If you have
received this communication in error, please notify the sender, then
destroy any remaining copies of this communication.





More information about the developers mailing list