Making It Easier To Start Working On Bugzilla

[Max Kanat-Alexander]

On Wed, 2005-12-21 at 10:01 -0700, Gregary Hendricks wrote:
> I have had multiple reviews get r- because it does not meet the coding
> style of the particular reviewer when in reality there is no good
> argument for changing it. If it is more efficient or reduces clock
> cycles, that is one thing, but otherwise if it works, why make 
> a developer change something over and over again to satisfy nits?

	For a long time, we didn't have an up-to-date or accurate Developer's
Guide. Now that we do, these things should no longer happen.

	Unless we're dealing with some area not covered in the Developer's
Guide (such as Object-Oriented architecture), review comments based on
style should be coming mostly from the Guide.

	Nits alone are never enough to justify r-.

> Just yesterday I spent litterally half my day helping rework a patch
> that  worked but wasn't "cool enough" to get accepted because it
> didn't use a particular implimentation of an algorithm.

	Which patch?

> Another thing that I have seen is reviewers that either do not read the
> comments of other reviews or forget their own comments. On at least two
> occasions I have had one reviewer tell me to do something one way and
> then get an r- on the next review (once a different reviewer and once the
> same reviewer) because I did it that way. This seems backwards.

	Hahahaha, yes, sometimes this happens. :-) You can always point it out,
when it happens. Sometimes the reviewer doesn't realize he's
contradicting the previous reviewer.

> Part of the beauty of open source in my mind is that we all have the 
> opportunity to share our understanding and we can all help each other
> learn new things.

	Yeah, definitely. :-)

	-Max
-- 
http://www.everythingsolved.com/
Competent, Friendly Bugzilla Services. And Everything Else, too.