control characters and Util::clean_text()

Frédéric Buclin LpSolit at gmail.com
Wed Dec 21 18:20:47 UTC 2005


> 	Replacing most calls to trim() with a call to clean_text() shouldn't be
> that hard, if that's what needs to be done.

Someone said on IRC that there are 150 occurences of trim() within the 
Bugzilla code. But I agree that it's not "hard" to change them (and is 
mostly harmless, unless you inadvertently remove newlines from 
comments). The only problem is that I'm not a fan of such changes on 
branches. In this case, bug 101380 should limit itself to bug summaries 
and nothing else.


> 	I don't particularly see a pressing reason to remove control characters
> in most cases, anyhow -- if somebody was silly enough to put a control
> character into a field, perhaps they intended for it to appear there.


I see no case where a user could be tempted to "honestly" use such 
characters.

LpSolit



More information about the developers mailing list