Proposal for Abstraction Layer for Modifications in Bug.pm

Paulo Casanova paulo.casanova at link.pt
Wed Jul 7 11:31:35 UTC 2004


Why not just fill in the default values when the bug is created in
Bugzilla::Bug::new_bug() or whatever? This way new values would just be set
over the default ones. Isn't that the Object-Oriented way?

Paulo

>> IIRC, 3 will only be called for completely new errors as all required field
>> should be filled with appropriate values.
>> Therefore, calling 3 everytime when committing will result in quite a few
>> unneeded calls.
>> 
>> Not that calling 3 in 4 is a problem, but IMHO it's better to do this
>> seperately.
> 
> OK. Then you can write a function called check_default_fields that
> quickly makes sure that all the default fields are filled in. I think it
> will add very little overhead, if commits are being batched anyway.
> 
> Or, you could have a little flag called "defaults_filled," and check
> that quickly. That would be pretty simple, and would add even less
> overhead.
> 
> -Max





More information about the developers mailing list