SQL call formatting style

Bradley Baetz bbaetz at acm.org
Wed Mar 26 08:15:20 UTC 2003

On Tue, Mar 25, 2003 at 11:57:59PM +0000, Gervase Markham wrote:
> No, I mean, one objection to the s/\s+/ /gs; thing was (if I read it 
> right) that it would remove newlines embedded in e.g. search strings in 
> queries. I was asking whether we actually do that?

Does it matter? Where was it that you were planning on munging this,
anyway? :)

I'm not even sure that we care about the stuff in error messages,
anyway. The only complicated ones are for Search.pm, and thats not the
focus of this anyway, since that query is dynamically generated. I'm
talking about the stuff which are (basically) static, simple, strings,
very, very, very occasionally with |$whereClause| added in the middle.

Not to mention that all of the "." stuff is annoying. Since we don't
have to keep opening an closing teh quotes for SqlQuote + friends, q{}
is probably nicer/simpler/etc

> Gerv


More information about the developers mailing list